search

soccerloway / quill-better-table

Module for better table in Quill, more useful features are supported.
MIT License
313 stars 120 forks source link

bugfix: history bugs #19

Open inevermore opened 4 years ago

soccerloway commented 4 years ago

@inevermore Thanks for your PR. When I apply your changes, the top column tool missed. And 'merge cells' did not work as usual.

inevermore commented 4 years ago

@soccerloway I didn't check all, just try to fix the history bug. Hope this pr can help you:smile:

soccerloway commented 4 years ago

@inevermore Thank you, your changes must be useful~:) It make insert/delete undo works well.

kagol commented 4 years ago

Thanks for your fixing, but will this change have side effects?

soccerloway commented 4 years ago

@kagol This is not a rigorous fixing, but inspiring. Don't use it for now.

kagol commented 4 years ago

This will cause some side effect when table has rowspan/colspan(initial/paste)

inevermore commented 4 years ago

@kagol Yes, this is not a qualified pr. I just focus on history bug. Hope this can inspire you.

inevermore commented 4 years ago

打个广告～ @soccerloway @kagol 钉钉文档招聘前端/java岗位，海量hc，急召p6/p7/p8（杭州/北京） 团队成员：微软技术专家、antd pro人员等 有兴趣可以加我微信：877089265 没兴趣也可以加，交个朋友哈～

kagol commented 4 years ago

@inevermore Thank you anyway~

sirgru commented 4 years ago

Any progress on this issue?

soccerloway commented 4 years ago

Actually no. I think it will take much time to fix the issue, but I'm busy in the end of the year. I'm sorry for the delay.