incompatibility with quill 2.0.0.4

soccerloway / quill-better-table

Module for better table in Quill, more useful features are supported.

MIT License

316 stars 119 forks source link

incompatibility with quill 2.0.0.4 #57

Open tedchou12 opened 4 years ago

tedchou12 commented 4 years ago

I found quill 2.0.0.4 https://libraries.io/npm/quill

I am using 2.0.0.4 because 2.0.0.3 has some input issues especially with the Chinese input I am using. (I think is a bug of 2.0.0.3

However I found out that quill-better-table has some errors with 2.0.0.4: Javascript errors:

quill-better-table.min.js:2152 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
    at table_selection_TableSelection.mouseDownHandler (quill-better-table.min.js:2152)
mouseDownHandler @ quill-better-table.min.js:2152

Could I know if there could be possible fixes? Thank you so much!

tedchou12 commented 4 years ago

seems like is an issue with disabling the default button behavior.

soccerloway commented 4 years ago

@tedchou12 I was just watching:)

soccerloway commented 4 years ago

Did you have it work well?

tedchou12 commented 4 years ago

@soccerloway Thank you! Actually, I found another error, when you combine (3,3) and (4,4), there will be empty space and those will cause errors:

quill-better-table.min.js:2162 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
    at HTMLDivElement.mouseMoveHandler (quill-better-table.min.js:2162)
mouseMoveHandler @ quill-better-table.min.js:2162
5quill-better-table.min.js:2942 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined
    at HTMLDivElement.<anonymous> (quill-better-table.min.js:2942)
(anonymous) @ quill-better-table.min.js:2942
2quill-better-table.min.js:2152 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
    at table_selection_TableSelection.mouseDownHandler (

tedchou12 commented 4 years ago

frocelu commented 4 years ago

I have the same error in quill version 2.0.0.3 and vue 2.6.11. And in using other function like Add table column right.

It seems like can't get the selection cell/column/row correctly.