search

sochix / TLSharp

Telegram client library implemented in C#
1.01k stars 380 forks source link

Add Session readonly field to TelegramClient #875

Closed MojtabaTajik closed 5 years ago

MojtabaTajik commented 5 years ago

Add Session readonly field which let user read session properties like current logedin user's Username & etc.

knocte commented 5 years ago

Make it a {get}-only property, not a field, please.

MojtabaTajik commented 5 years ago

Make it a {get}-only property, not a field, please.

It's already get only. The code is expression bodied style of get only.

knocte commented 5 years ago

I would prefer to make it explicit just in case (more verbose but more readable).

MojtabaTajik commented 5 years ago

@knocte Done

knocte commented 5 years ago

Now the git commit message doesn't contain the good description that you had added before: "Add Session readonly field which let user read session properties like current logged-in user's Username & etc.". Please add it.

knocte commented 5 years ago

I said the commit message, not the PR title.

knocte commented 5 years ago

Do you need help with interactive rebase?

knocte commented 5 years ago

@MojtabaTajik I merged your improvement manually in the master branch: https://github.com/sochix/TLSharp/commit/8a15feea7c9357aab5bf6df504d45ae2077009d4