Code refactoring - Githubissues

sochix / TLSharp

Telegram client library implemented in C#

1.01k stars 380 forks source link

Code refactoring #901

Closed CheshireCaat closed 4 years ago

CheshireCaat commented 4 years ago

This PR contains some commits that contains code refactoring for:

TeleSharp.Generator:

Removed unused references in Program.cs and replace 'String' to 'string'
Added JsonProperty attribute for each property in models
Models moved to separate folders

TLSharp.Core.MTProto.Serializers:

Fix naming for methods and remove unused method

TLSharp.Core.DataCenter:

Remove redundant setters for properties

knocte commented 4 years ago

I guess you tested TLSharp after these changes?

CheshireCaat commented 4 years ago

Yes, i always check that library working fine using small console-client. Should I test specific functions? I guess that this PR not contains changes that may be break functionality of TLSharp.

Only thing that TeleSharp.Generator wasn't tested by me.

knocte commented 4 years ago

Well, the generator is the most important thing to test here because you used new Json attributes.

CheshireCaat commented 4 years ago

Ok, i tested it now with 23 layer from official docs. It works without any exceptions.