search

sochix / TLSharp

Telegram client library implemented in C#
1.01k stars 380 forks source link

Fix problem with TLRequestGetStickerSet #905

Closed raznahan closed 4 years ago

raznahan commented 4 years ago

When trying to SendRequest with TLRequestGetStickerSet throws an exception saying "cannot cast object of type TeleSharp.TL.TLStickerSet to TeleSharp.TL.Messages.TLStickerSet".

knocte commented 4 years ago

@CheshireCaat please review

CheshireCaat commented 4 years ago

@raznahan, a small tip for the future - use a short header for commit, and write more below, for example:

Fix type of TLStickerSet Set property (short description)

Change type of Set property from TLStickerSet to TL.TLStickerSet (more additinal info)

CheshireCaat commented 4 years ago

@knocte I am afraid that in the future, if you need to update the layer, this problem may appear again. I’ll try to look at the TeleSharp.Generator for problems when generating such classes later.

knocte commented 4 years ago

use a short header for commit, and write more below,

The commit message should also include the number of the github issue that is fixing.

I’ll try to look at the TeleSharp.Generator for problems when generating such classes later.

Sounds good!

raznahan commented 4 years ago

@raznahan, a small tip for the future - use a short header for commit, and write more below, for example:

Fix type of TLStickerSet Set property (short description)

Change type of Set property from TLStickerSet to TL.TLStickerSet (more additinal info)

Thanks! I'm kinda new to git, so will try next time for sure.