sochix / TLSharp

Telegram client library implemented in C#

1.01k stars 380 forks source link

[WIP] Asynchronous Network #919

Closed aarani closed 4 years ago

aarani commented 4 years ago

I created this as a PoC it works but it's not great I want to propose a new branch for everyone to work on this as it's extremely necessary for having a functional telegram api PS: I use NetCoreServer library and it needs a .NET Framework 4.6 Update

aarani commented 4 years ago

@knocte Please check this commit and tell me your opinion

knocte commented 4 years ago

@CheshireCaat can you test this?

knocte commented 4 years ago

@aarani : to begin with, can you separate this into 2 PRs? another one which just upgrades the .NETFramework version

aarani commented 4 years ago

@CheshireCaat can you test this?

I should say that i used a console application to test it because i couldn't update the test projects to .net framework 4.6

aarani commented 4 years ago

@aarani : to begin with, can you separate this into 2 PRs? another one which just upgrades the .NETFramework version

Sure, I try doing it but test projects are pain to update

knocte commented 4 years ago

because i couldn't update the test projects to .net framework 4.6

why you couldn't upgrade them?

knocte commented 4 years ago

Sure, I try doing it but test projects are pain to update

why a pain? please share more information with us, we're also developers, not managers :)

aarani commented 4 years ago

because i couldn't update the test projects to .net framework 4.6

why you couldn't upgrade them?

Visual studio gave me a weird error when I tried doing it so I did not bother to figure out what's wrong. I try again.

Capture

aarani commented 4 years ago

Sure, I try doing it but test projects are pain to update

why a pain? please share more information with us, we're also developers, not managers :)

Sure, but I wanted to take a look at it myself first and then bother you guys with it 😄

knocte commented 4 years ago

Visual studio gave me a weird error when I tried doing it so I did not bother to figure out what's wrong. I try again.

I think this happened to me once, when I wrote "4.6.0" instead of "4.6" (the latter is the correct version number). Maybe this was the mistake?

If not, try simply restarting Visual Studio like this guy says here: https://stackoverflow.com/a/56597422/544947

aarani commented 4 years ago

Visual studio gave me a weird error when I tried doing it so I did not bother to figure out what's wrong. I try again.

I think this happened to me once, when I wrote "4.6.0" instead of "4.6" (the latter is the correct version number). Maybe this was the mistake?

If not, try simply restarting Visual Studio like this guy says here: https://stackoverflow.com/a/56597422/544947

wow restarting worked 😆 I will try running the tests too.

aarani commented 4 years ago

@aarani : to begin with, can you separate this into 2 PRs? another one which just upgrades the .NETFramework version

920

aarani commented 4 years ago

Sorry, I accidentally pushed my api_id and api_hash and had to force push it this pull request is toast