search

sochix / TLSharp

Telegram client library implemented in C#
1.01k stars 380 forks source link

Github Action Workflow #921

Closed aarani closed 4 years ago

aarani commented 4 years ago

Linux Only : https://github.com/aarani/TLSharp/runs/551719993 Linux & Windows: https://github.com/aarani/TLSharp/runs/551780218

@knocte

knocte commented 4 years ago

Good job! Let's add macOS too (in macOS you can use msbuild, no need to use xbuild).

aarani commented 4 years ago

Good job! Let's add macOS too (in macOS you can use msbuild, no need to use xbuild).

macOS msbuild doesn't support .NET Framework afaik

knocte commented 4 years ago

macOS msbuild doesn't support .NET Framework afaik

But I mean Mono. And macOS+mono already includes msbuild (which is now opensource).

knocte commented 4 years ago

macOS msbuild doesn't support .NET Framework afaik

I meant that it does support it, in fact msbuild is actually the .NET framework tool (the .NET Core tool to build is "dotnet build" ;) ).

knocte commented 4 years ago

Great! this is almost ready, I'll now just point out some other nitpicks

knocte commented 4 years ago

beautiful! is there a way to have variables in the workflow to not repeat the nuget URL 3 times?

aarani commented 4 years ago

beautiful! is there a way to have variables in the workflow to not repeat the nuget URL 3 times?

Done but downloading using powershell still not working

knocte commented 4 years ago

I've had problems in the past with regressions in the newest nuget versions (and suddenly the CI breaking without changing anything can be scary&annoying) so let's switch to a specific version: I recommend 5.4.0

aarani commented 4 years ago

I've had problems in the past with regressions in the newest nuget versions (and suddenly the CI breaking without changing anything can be scary&annoying) so let's switch to a specific version: I recommend 5.4.0

Done

aarani commented 4 years ago

@knocte Downloading NuGET on windows when using environment variables fails. any idea why ?

knocte commented 4 years ago

Downloading NuGET on windows when using environment variables fails. any idea why ?

not sure, I'll investigate

aarani commented 4 years ago

Yes that worked. Final Log: https://github.com/aarani/TLSharp/actions/runs/68830282

knocte commented 4 years ago

Now let's add the badge for the build status, in the readme file, and I merge :)

In markdown format should be:

[![CI build status badge](https://github.com/sochix/TLSharp/workflows/CI/badge.svg)]
knocte commented 4 years ago

(And remove the WIP from the title?)

aarani commented 4 years ago

@knocte Can you please remove the appvoyer check?