sochix / TLSharp

Telegram client library implemented in C#
1.01k stars 380 forks source link

Added an IPv4/IPv6 toggle to TelegramClient constructor #925

Closed solarin closed 4 years ago

knocte commented 4 years ago

@solarin now you forgot to include the changes to the .csproj file :)

And please configure your editor to use 4 spaces, not tabs.

solarin commented 4 years ago

@solarin now you forgot to include the changes to the .csproj file :) And please configure your editor to use 4 spaces, not tabs.

i'm getting crazy

solarin commented 4 years ago

also added some methods that i needed for my project

knocte commented 4 years ago

also added some methods that i needed for my project

Please don't include those here, open a different PullRequest for that.

solarin commented 4 years ago

also added some methods that i needed for my project

Please don't include those here, open a different PullRequest for that.

ok i deleted these and created a new PR

solarin commented 4 years ago

i think i have changed all the spaces back to the originals

knocte commented 4 years ago

i think i have changed all the spaces back to the originals

You missed many, sorry, click here and you will see them all: https://github.com/sochix/TLSharp/pull/925/files

knocte commented 4 years ago

Thanks for your patience. I will merge this tonite or tomorrow.

solarin commented 4 years ago

i propose to rename DataCenterIPVersion to DataCenterIPVersions and also move this file under namespace TLSharp.Core.Types

because we need other enums and other types that we need logically, although they have a different name or type at protocol-level

One example is ParticipantTypes (Recents, Restricted, Admins, Bots, Search, Contacts, Kicked, Banned)

which at protcol level exists in different ways.

Saleh-Software commented 4 years ago

var client = new TelegramClient(apiId, apiHash); await client.ConnectAsync();

this code not have dependency !! How Can Now Connect To Telegram? And Please Put Poll Method For Vote Channel

knocte commented 4 years ago

this code not have dependency !

what dependency? what are you talking about?