sochix / TLSharp

Telegram client library implemented in C#
1.01k stars 380 forks source link

GetFullChat + GetAllChats + MakeAuthBotAsync + Other methods #926

Open solarin opened 4 years ago

solarin commented 4 years ago
knocte commented 4 years ago

You need to remove the DataCenterIPVersion stuff from here, otherwise the PRs are not separate (if I merge the other one, there will be conflicts here).

solarin commented 4 years ago

You need to remove the DataCenterIPVersion stuff from here, otherwise the PRs are not separate (if I merge the other one, there will be conflicts here).

ok i think it's ok now

knocte commented 4 years ago

@aarani can you review this PR?

solarin commented 4 years ago

@knocte as for the Array.ForEach, the only replacement i am aware of is to do a classic for(int i...). i wouldn't use any other list in this case as they would introduce a worse overhead than the Array.ForEach.

knocte commented 4 years ago

as for the Array.ForEach, the only replacement i am aware of is to do a classic for(int i...). i wouldn't use any other list in this case as they would introduce a worse overhead than the Array.ForEach.

Let's use a normal foreach then. More reasoning here: https://docs.microsoft.com/en-gb/archive/blogs/ericlippert/foreach-vs-foreach