search

sochix / TLSharp

Telegram client library implemented in C#
1.01k stars 380 forks source link

address an issue with the datacenter selection... #938

Closed solarin closed 4 years ago

solarin commented 4 years ago

that could select datacenters which were not supporting standard communication

solarin commented 4 years ago

@knocte is my concern clear now why we should push the other fix first?

knocte commented 4 years ago

not clear man, what would happen if I merge only the line that filters the MediaOnly DCs and not the session save? what happens in that case?

solarin commented 4 years ago

it works. then when you push fix 937 it won't work. because you need the line session.save

solarin commented 4 years ago

i don't know what else i can say, try it if you don't believe/understand/unsure of what i am saying. i have been debugging for hours and now also documenting it for many more hours. i might sound arrogant, but i value my time a lot.

knocte commented 4 years ago

but i value my time a lot.

It's not that I don't believe you, it's that I want to understand before merging.

it works. then when you push fix 937 it won't work. because you need the line session.save

Well, then I will merge first a commit filtering the MediaOnly, whose commits message says that it fixes bug https://github.com/sochix/TLSharp/issues/935. After that, I'll modify PR 937 to include that Save() call. And we're done. And each commit fixes a separate thing. Ok with this?