fix commas and periods in amount field upstream

TimDaub commented 5 years ago

Scope

Currently, the burner wallet uses the i18n package to do localization
We're about to use react-i18next: https://github.com/leapdao/plasma-burner-wallet/pull/195
Try the following on your burner-wallet:
- Depending on your browser language, try sending an amount of money with decimals but alternate between a period . and a comma ,. So in the SendToAddress.js view try putting into the <Input /> 2.5 or 2,5.
You'll notice that often decimal values but particular their delimiter (so commas or periods) will bug the process

Fix this issue upstream (leapdao/plasma-burner-wallet)
Then create a PR to fix this issue also in this repo
Make sure that you test various languages that prefer commas over periods and vice versa

It might make sense to get in contact with @MaxStalker and/or @iamonuwa as they've already done some work on this topic and might know more!

bounty gardener: @TimDaub / 10% bounty worker: name / 75% bounty reviewer: name / 15%

iamonuwa commented 5 years ago

I would love to work on this. As I already implemented it on burner. I'll rebase both

TimDaub commented 5 years ago

@iamonuwa I unassigned you from here as I remember you mentioned that you won't do it, correct?

iamonuwa commented 5 years ago

Right

TimDaub commented 5 years ago

Fixed in #118