socialappslab / appcivist-platform

Core AppCivist Platform
http://citris-uc.org/social-apps-lab/project/appcivist-2/
Other
5 stars 0 forks source link

Make all URLs canonical #1143

Open mitar opened 3 years ago

mitar commented 3 years ago

We should get rid of this dual URLs, where public and private URLs are different. Let's:

mitar commented 3 years ago

@yolile This issue is something you should be doing in the future, after finishing current tasks. Before that, can you please tell how much work do you think this is and if everything above makes sense. I do not know all the details so maybe I missed something or something makes no sense or could be done simpler.

yolile commented 3 years ago

So in all models, we should have a UUID stored alongside the numerical primary key. Primary key is still used for foreign keys.

This is already as that in the backend.

The major changes are in the frontend, as there is a lot of logic on what to do accordingly to the URL and if the URL has a uuid or and id on it , eg https://github.com/socialappslab/appcivist-pb-client/blob/7281ea8a1bf5b6ae8f381fd8498bb1bc166219d3/app/v2/controllers/main.js#L115

As the code in the frontend is sparse in different files I anticipate that there will be needed a lot of tests and refactoring. Therefore, I estimate around 16 to 20 hours of work

mitar commented 3 years ago

OK. Based on this, I would have moved this issue for you to work on. I think this is a reasonable chunk you could then do, a part this month and a part next month. So please start working on this.