search

socialcast / devise_oauth2_providable

Rails3 engine integrating OAuth2 authentication with Devise
MIT License
219 stars 102 forks source link

Namespace for Client model #15

Closed yliu163 closed 12 years ago

yliu163 commented 13 years ago

I encountered some namespace conflicts when using the client class. I think it's desirable to specify the namespace for all the Client constant appearing in the code. Thanks.

wireframe commented 12 years ago

i have a proposed change for this by using a rails 3.1 mountable engine which will isolate the models into the Devise::Oauth2Providable namespace and all database tables will be prefixed with oauth2.

the changes are available on the mountable-engine if you would care to review.

ZenCocoon commented 12 years ago

Looks like you deleted the Clients management, is that not something you like to be included out of the box ?

wireframe commented 12 years ago

correct. i don't forsee this gem supporting client management out of the box. since client management is highly subject to the needs of each application, it does not seem like a general concern to be included in this gem and it is well outside the scope of the oauth2 spec.

see issue #17 for more discussion.

ZenCocoon commented 12 years ago

Makes sense. Thanks for your explanations.