search

socialcast / devise_oauth2_providable

Rails3 engine integrating OAuth2 authentication with Devise
MIT License
219 stars 102 forks source link

spec_helper improvements #22

Closed t6d closed 12 years ago

t6d commented 12 years ago

Hi,

we decided to integrate your gem in our system and along the way we hope to contribute a little. We started by adding support for auto migrating the database whenever the test suite is executed. We also removed .rvmrc and .rspec from the repository because, in our opinion, these two files only contain developer specific settings and should therefore not be tied to the entire project.

Kind regards, the flinc dev team

wireframe commented 12 years ago

thanks for the patch!

I've pulled in several of your contributions and appreciate the work. there are a few remaining changes that i'm going to hold of for now. i prefer the .rvmrc file being checked in to ensure that the project is guaranteed to pass under known conditions. what ruby version do you use with your app? I'm considering updating the required version to 1.9.x.

removing the .rspec file is okay since that is clearly developer specific syntax suger.