search

socialcast / devise_oauth2_providable

Rails3 engine integrating OAuth2 authentication with Devise
MIT License
219 stars 102 forks source link

Mass assignment fix #39

Closed karlfreeman closed 12 years ago

karlfreeman commented 12 years ago

Rails 3.2.2 with config.active_record.whitelist_attributes = true breaks functionality

karlfreeman commented 12 years ago

should close #35

ZenCocoon commented 12 years ago

+1, would be happy to have this merged.

emptyflask commented 12 years ago

+1

karlfreeman commented 12 years ago

Any chance this could be scheduled to be pulled in on the next version bump? Rails 3.2.3 has been out for a while now and needs this change :)

winfred commented 12 years ago

yes plz

colszowka commented 12 years ago

+1 :)

jphenow commented 12 years ago

This should get merged I think?

ZenCocoon commented 12 years ago

@wireframe could you please merge this commit, it currently push people to disable config.active_record.whitelist_attributes = true which increase potential security issues.

karlfreeman commented 12 years ago

thanks @ZenCocoon :)

wireframe commented 12 years ago

thanks for bumping this pull request. I was out of the office when the original pull request was filed, and so it wasn't on my radar.

I've incorporated the patch with a few modifications and pushed v1.1.2 to rubygems.

karlfreeman commented 12 years ago

@wireframe No problem :+1:

ZenCocoon commented 12 years ago

@wireframe brilliant, thanks for the merge.