search

socialfoundations / folktables

Datasets derived from US census data
MIT License
234 stars 20 forks source link

Replace `sklearn` with `scikit-learn` #32

Closed jansim closed 1 year ago

jansim commented 1 year ago

Hello, thanks for building this lovely package!

Since sklearn is being deprecated as a package name in favor of scikit-learn, this leads to errors when trying to install the package during certain times (as part of their brownout strategy). These errors will become more common as the times of the brownout are increased.

More info on this issue here: https://pypi.org/project/sklearn/

So far I've only noticed the setup.py actually referencing sklearn, so the solution here might be as easy as replacing sklearn in the setup.py with scikit-learn. All import calls should remain unaffected.

AndreFCruz commented 1 year ago

FYI, just had an install error based on sklearn being deprecated:

Screenshot 2023-02-01 at 14 11 49

Using python 3.9.16 on an Intel mac.