socialincome-san / public

Fighting global poverty with the help of everyday people and your coding skills. Public repository of the NGO and global initiative Social Income.
https://socialincome.org
Other
84 stars 23 forks source link

feature(website): styling newsletter signup page #784

Closed ssandino closed 5 months ago

ssandino commented 6 months ago

Current state:

Screenshot 2024-03-25 at 01 05 54

Previous state:

Screenshot 2024-03-25 at 01 07 04
vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 1 resolved Apr 21, 2024 9:24am
github-actions[bot] commented 6 months ago

Visit the preview URL for this PR (updated for commit 9fabb44):

https://si-admin-staging--pr784-sandino-styling-news-ijtjdqki.web.app

(expires Sun, 28 Apr 2024 09:25:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

ssandino commented 6 months ago

Per @mkue's request in #781, I've added styling to the signup form. IMO we can start with just first name and email for minimal data collection. Ideally, we'd automatically detect and save country and language in the background – this data can be useful for future emails (i.e. country comparison).

@mkue + @thomasbrenner-ch inputs are very welcome. Specifically also on the minor issues of the current PR:

Screenshot 2024-03-25 at 01 41 20
mkue commented 6 months ago

https://public-git-sandino-styling-newsletter-signup-page-social-income.vercel.app/en/ch/newsletter

mkue commented 6 months ago

FYI @brennerthomas:

I made a tiny change (https://github.com/socialincome-san/public/pull/784/commits/e125aa009551b5720071132f58cabf3179b76afc). The form already has a submitting state, so you don't have to track it separately:

https://react-hook-form.com/docs/useform/formstate