socialincome-san / public

Fighting global poverty with the help of everyday people and your coding skills. Public repository of the NGO and global initiative Social Income.
https://socialincome.org
Other
70 stars 24 forks source link

feature(website): styling cookie and newsletter signup banner #793

Closed ssandino closed 2 months ago

ssandino commented 2 months ago

Future Improvements: As new components are developed, consider removing the custom classes from the buttons and instead utilize the plain component directly in the future. This approach will streamline the codebase. However, the adjustments made in this update already represent an improvement. Therefore, I advocate for proceeding with deployment (if now code changes needed).

Before:

before3

After:

Note the white background is hardly visible in the GIF (but it's there) after1

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 10:18pm
github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit bcd2b5d):

https://si-admin-staging--pr793-sandino-styling-bann-vedselb1.web.app

(expires Thu, 11 Apr 2024 22:18:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

mkue commented 2 months ago

Closing this, as banners are not shown at the same time anymore.