search

socialincome-san / public

Fighting global poverty with the help of everyday people and your coding skills. Public repository of the NGO and global initiative Social Income.
https://socialincome.org
Other
70 stars 24 forks source link

feature (website): sections for new landing page-2 #805

Closed DarkMenacer closed 2 months ago

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:16am
DarkMenacer commented 2 months ago

@mkue @ssandino I'm done with the next section: Monthly Income (albeit it is cosmetic for now) For some reason, even the previous commits are being displayed here but thankfully only the files that I changed for the latest commits are displayed for the 'Files changed' section.

Also Mike, I had some doubts regarding taking the input and the overall working of the input component.

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 19a621a):

https://si-admin-staging--pr805-pranav-new-landing-p-mwtrwdj1.web.app

(expires Wed, 08 May 2024 08:17:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

ssandino commented 2 months ago

@mkue not sure if you are up to date, but @DarkMenacer will present the landing page at the upcoming Townhall ❤️

DarkMenacer commented 2 months ago

@mkue, @ssandino Done with yet another section, Mobile Illustrations

DarkMenacer commented 2 months ago

@mkue, @ssandino Also wrapped up explainer-video Also at this point, I realise some font size inconsistencies Do not worry, once I am done with all sections, I’ll have some sort of a overall bird eye view at the entire page and make the consistency changes For now my main focus is to get the pages up and running

DarkMenacer commented 2 months ago

@mkue @ssandino Let me know once you have gone through the code Heavy changes coming in...I'll keep them on hold until you review these ones I'll push the next batch after this one

ssandino commented 2 months ago

Thanks @DarkMenacer – I went through it visually and must say, we are definitely on the right track here. Nice to see it coming along.

I had some doubts regarding taking the input and the overall working of the input component.

In my opinion, the monthly income input field can be a simple placeholder for now and addressed later, aligned with the donation process. Don't loose time there.

A big (design) step forward will be when the blue sections extend across the full width of the page. Looking forward to this – but this might be your "heavy changes coming in"!

DarkMenacer commented 2 months ago

A big (design) step forward will be when the blue sections extend across the full width of the page.

I'll need @mkue 's help here. It seems that, that shade of blue hasn't been added as the property type for BaseContainer component. I tried adding primary to the list, but it doesn't seem to change anything So I just proceeded without the background for now

*edit: I can actually remove the BaseContainer completely (and in that case the entire section is blue). But I don't think Michael would be proud of me, if I did that (so didn't even entertain the idea)

DarkMenacer commented 2 months ago

@mkue @ssandino Done with quotes sections as well (Also had to rearrange testimonials section as I was confused between the two earlier) Now only 5 things remain

I'll hopefully wrap up Journal and SDG Goals by tonight

DarkMenacer commented 2 months ago

@mkue Extended background color to blue for relevant sections despite it displaying an error. Let's look into this whenever you have time