Closed ssandino closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Visit the preview URL for this PR (updated for commit ea5d3b4):
https://si-admin-staging--pr924-sandino-new-ngo-list-0hbcqo2s.web.app
(expires Thu, 14 Nov 2024 13:39:45 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676
[x] specific images per NGO (Mathilda just did this for another section, maybe you can just use her code and way of doing it – here the commit)
[x] adding the possibility to have paragraphs within the "org-description" to make it more reader friendly
[x] lil bug: the mouse over text for the SDG always says SDG 1 (also for other sdg goals), see screenshot
[x] how would i make a link within the text (for example org description)?
[x] feature: If there are no links at all (there are some NGOs who don't have anything online), then "Visit online" row should not be shown.
[x] feature: Also the same for the quote. Most likely we add some new ones, which have not yet a quote in the beginning (would be weird to ask them before they can authentically tell us)
[x] add "linkedin" and "youtube" as other possible link for a NGO (added one for JNJF and Reachout has Youtube)
[x] lil bug: Behind the flag icon it shows still the abbreviation instead of the country name (that is stored in the countries translation file), see screenshot
[x] to show the corresponding flag for the "org-country" (not sierra leone flag hardcoded), however as we have for the next month only SL it can also stay hardcoded. The flags would be all somewhere (like we load it for the currencies)
[ ] a circle with white background around closing X for dialog popup (but might be done on component level)
[x] make badges always 1 line only
@mkue excellent effort from @DarkMenacer. Nicely done! Vercel Preview
Thx @mkue for the review.
Generally looks great! Thanks for doing this :)
I pushed a small commit that moves the installed dependency to the ui
package and updates the height of the Dialog to 90%. I think it looks nicer if there is a margin at the bottom and at the top.
Ping me if you have any questions regarding my comments.
The changes introduce new localization content in the website-common.json
file, adding sections for social media links and details about the Sustainable Development Goals (SDGs). A new file, website-partners.json
, is created to provide structured metadata about partner organizations, including their missions and statuses. Additionally, several new React components are added, such as Separator
, Hero
, NgoCard
, and NgoList
, enhancing the UI for displaying NGO information. The package.json
is updated to include a new dependency and broaden version specifications for existing dependencies.
File Path | Change Summary |
---|---|
shared/locales/en/website-common.json | Added new links section with social media entries and a comprehensive sdg section for SDGs. |
shared/locales/en/website-partners.json | Introduced a structured JSON object containing metadata about partner organizations and NGOs. |
ui/package.json | Added dependency "@radix-ui/react-separator": "^1.1.0" and updated version constraints for others. |
ui/src/components/separator.tsx | Added new Separator component wrapping SeparatorPrimitive.Root with props for customization. |
ui/src/index.ts | Added export for the new Separator component. |
website/src/app/[lang]/[region]/(website)/partners/(sections)/hero.tsx | Introduced Hero function component for dynamic title and subtitle rendering. |
website/src/app/[lang]/[region]/(website)/partners/(sections)/ngocard.tsx | Added NgoCard component to display NGO information with props for various attributes. |
website/src/app/[lang]/[region]/(website)/partners/(sections)/ngolist.tsx | Created NgoList component for rendering a list of NGOs using NgoCard . |
website/src/app/[lang]/[region]/(website)/partners/page.tsx | Added Page component to structure the layout with Hero and NgoList . |
shared/locales/de/website-common.json | Added new links and sdg sections with German translations for social media and SDGs. |
shared/locales/de/website-partners.json | Introduced structured metadata for partner organizations in German localization. |
shared/locales/fr/website-common.json | Added new links and sdg sections with French translations for social media and SDGs. |
shared/locales/fr/website-partners.json | Created a new JSON file for French localization of partner organizations. |
shared/locales/it/website-common.json | Added new links and sdg sections with Italian translations for social media and SDGs. |
shared/locales/it/website-partners.json | Introduced structured metadata for partner organizations in Italian localization. |
In the garden of change, we hop and we play,
New links and NGOs brighten the day.
With missions and partners, our goals intertwine,
Together we flourish, like vines that align.
So let’s share the news, let our voices be heard,
For each little change is a hop towards the world! 🐰✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Release Notes
New Features
Improvements
Documentation