search

socialincome-san / public

Fighting global poverty with the help of everyday people and your coding skills. Public repository of the NGO and global initiative Social Income.
https://socialincome.org
Other
91 stars 26 forks source link

transparent bg on nav when hero video #929

Closed mdumond closed 2 weeks ago

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 6:51pm
mdumond commented 4 weeks ago

yes we did not test at all :upside_down_face: I will check that this week end

mdumond commented 3 weeks ago

I have just pushed a fix that fixes the nav background on scroll

ssandino commented 3 weeks ago

works 🙌🏼

mkue commented 2 weeks ago

Very very cool🙌🏼 I'm super happy this is resolved now. It bothered me quite a bit that I didn't find a better solution initially🙃

I pushed one last commit that sets the default color to null in the useNavbarBackgroundColor() hook. This a) resolves an issue that the navbar stayed blue when navigating back to the home page, and b) makes it a bit more clear that this hook is there to overwrite the default background color (which is blue due to theme-blue that is used on the NavbarClient component).