socialincome-san / public

Fighting global poverty with the help of everyday people and your coding skills. Public repository of the NGO and global initiative Social Income.
https://socialincome.org
Other
91 stars 26 forks source link

bugfix(website): display the correct logos in quotes section on home page #930

Closed mdumond closed 3 weeks ago

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:13pm
github-actions[bot] commented 4 weeks ago

Visit the preview URL for this PR (updated for commit a912081):

https://si-admin-staging--pr930-917-logo-quotes-9ws44e1a.web.app

(expires Thu, 31 Oct 2024 20:01:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

mdumond commented 4 weeks ago

Some notes here: the worldbank logo is much stronger than the other 2, so either it needs to be a bit smaller, or the other 2 need to grow a bit.

Also, I have run the svgs into https://svgomg.net/, it's a tool that allows to reduce the svg file sizes, though they were already quite good, they got reduced by ~10% each

I had to move the svgs to the /public folder, I did not remove them from (assets), maybe we should check that they are not used anywhere else and remove them from there so they are not doubled