search

socialpandas / sidekiq_monitor

Advanced monitoring for Sidekiq
MIT License
230 stars 35 forks source link

This fixes #25 #26

Closed harssh closed 10 years ago

abrambailey commented 10 years ago

Hopefully someone hears you.

tombenner commented 10 years ago

Thanks for submitting this! It would unfortunately break in Rails 3 apps, though, in which the third argument of distance_of_time_in_words is a boolean. If you'd like to fix this, perhaps you could open a new PR that contains something like:

if Rails::VERSION::MAJOR >= 4
  words = distance_of_time_in_words(from_time, to_time, include_seconds: true)
else
  words = distance_of_time_in_words(from_time, to_time, true)
end
words.gsub('less than ', '').gsub('about ', '')

I'd rather we didn't add this onto this PR, so that we can keep the revision history clean. If you don't have time to do this soon, I can probably do it within the next couple of days. Thanks!

abrambailey commented 10 years ago

Tom, please pull https://github.com/socialpandas/sidekiq_monitor/pull/28

harssh commented 10 years ago

@tombenner No problem I will add that to PR

harssh commented 10 years ago

@tombenner Thanx for the suggestion I have added suggested changes ... Apprecite it :+1:

harssh commented 10 years ago

You can merge this PR now

tombenner commented 10 years ago

Thanks! #28 was cleaner (it removed the original faulty line), so I've merged that. The new release (0.1.5) contains this fix.