search

socib / Leaflet.TimeDimension

Add time dimension capabilities on a Leaflet map.
MIT License
433 stars 138 forks source link

Fix timedimension.layer.wms for date 1970-01-01 UTC #214

Closed erick-otenyo closed 2 years ago

erick-otenyo commented 2 years ago

1970-01-01T00:00:00.000Z is 0 in milliseconds. A check for time = 0 returned the base layer without the time param thus the correct request is never made.

This pull request just removed the check for time = 0

Related to : #83

bielfrontera commented 2 years ago

Hi @erick-otenyo, thanks for your PR!

You shouldn't modify files on dist folder, as they are built from the source code files that are inside the src folder. So, can you modify your PR and include only modifications in files from the src folder?

erick-otenyo commented 2 years ago

Hi @bielfrontera

Should be fine now ?

bielfrontera commented 2 years ago

Yes, it's fine! I have squashed the 3 commits into a unique commit to simplify history. I will publish the release 1.1.2 with this fix and other changes soon! Thanks @erick-otenyo! :)

erick-otenyo commented 2 years ago

Great. You are welcome!