search

sociomantic-tsunami / dhtproto

Distributed Hash Table protocol definition, client, fake node, and tests
Boost Software License 1.0
5 stars 22 forks source link

Increase the size of the legacy Put request's record size limit #189

Closed gavin-norman-sociomantic closed 5 years ago

gavin-norman-sociomantic commented 5 years ago

(The limit must be <= the limit set in https://github.com/sociomantic-tsunami/dhtnode/issues/181, so that the client is limited to writing records that can fit in a batch request's batch.)

gavin-norman-sociomantic commented 5 years ago

This is what needs to change: https://github.com/sociomantic-tsunami/dhtproto/blob/v14.x.x/src/dhtproto/client/legacy/DhtConst.d#L69

gavin-norman-sociomantic commented 5 years ago

The constant is used in one location: in the legacy Put request.

gavin-norman-sociomantic commented 5 years ago

Two points here:

  1. Rather than changing the constant in dhtproto, we should make this value configurable.
  2. This Put size limit is only enforced on the node side, which makes the whole thing much easier. (I was working on the assumption that the client enforces this limit.)