search

sociomantic-tsunami / dhtproto

Distributed Hash Table protocol definition, client, fake node, and tests
Boost Software License 1.0
5 stars 22 forks source link

Stop using deprecated RecordBatch.DefaultMaxBatchSize #203

Closed don-clugston-sociomantic closed 5 years ago

don-clugston-sociomantic commented 5 years ago

RecordBatch.DefaultMaxBatchSize is marked as deprecated, yet is still used by dhtproto itself. Change the code to use the identically-defined RecordBatcher.DefaultMaxBatchSize instead.

This removes the annoying deprecation warning.

gavin-norman-sociomantic commented 5 years ago

Slightly elaborated version: #204.

don-clugston-sociomantic commented 5 years ago

Excellent! Your PR would be even better, if it would compile :)

matthias-wende-sociomantic commented 5 years ago

Another nice thing is that we merged the (almost) same PR in the neo branch last year :). https://github.com/sociomantic-tsunami/dhtproto/pull/160. (Exclude me in the we)