search

sociomantic-tsunami / dhtproto

Distributed Hash Table protocol definition, client, fake node, and tests
Boost Software License 1.0
5 stars 22 forks source link

Adapt Get, Put, GetChannels to use new SupportedCode from swarm #90

Closed gavin-norman-sociomantic closed 6 years ago

gavin-norman-sociomantic commented 6 years ago

Gah, it's too early in the year for flaky tests :(

gavin-norman-sociomantic commented 6 years ago

Interesting... it seems that reading and checking the started / error code in the handleSupportedCode method (instead of in the handle method) fixes the flaky tests. I'm not entirely sure why.

gavin-norman-sociomantic commented 6 years ago

Green now.

Interesting... it seems that reading and checking the started / error code in the handleSupportedCode method (instead of in the handle method) fixes the flaky tests. I'm not entirely sure why.

@nemanja-boric-sociomantic interested whether you have any thoughts on that. The most obvious thing I can think of is what will happen in AllNodesRequest.run. I don't see what difference that would make, though.

nemanja-boric-sociomantic commented 6 years ago

I'm sceptical towards the fact that this caused/fixed flaky tests :thinking: .

gavin-norman-sociomantic commented 6 years ago

Ditto.

gavin-norman-sociomantic commented 6 years ago

It was very repeatable, though. With the previous change: ~2/4 builds would fail. With the current change: no builds fail.

gavin-norman-sociomantic commented 6 years ago

How ironic that as soon as I type that, I notice that the current build has failed with the same problem :D

gavin-norman-sociomantic commented 6 years ago

Moved flaky part to https://github.com/sociomantic-tsunami/dhtproto/pull/93.

nemanja-boric-sociomantic commented 6 years ago

:+1: Looks very noncontroversal.