search

sociomantic-tsunami / dlsproto

Distributed Log Store protocol definition, client, fake node, and tests
Boost Software License 1.0
3 stars 18 forks source link

[WIP] Factor out fakedls.DlsNode #101

Open gavin-norman-sociomantic opened 6 years ago

gavin-norman-sociomantic commented 6 years ago

The old code structure was: DlsNode : swarm.node.model.NeoNode.NodeBase!(DlsConnectionHandler) Dls!(DlsNode) : turtle.env.model.Node.Node (the latter in swarm)

So the aspects of the node that integrate with turtle were separated from the actual node implementation.

The new structure is: turtle.env.Dls.Dls : TestNode!(DlsConnectionHandler) (the former in dlsproto)

gavin-norman-sociomantic commented 6 years ago

I believe the separation of turtle node from the actual node implementation is a historical artefact from the days when the fake nodes lived partially in turtle. It seems to be unnecessary now.

gavin-norman-sociomantic commented 6 years ago

Requires https://github.com/sociomantic-tsunami/swarm/pull/353.