Use SchedulingDlsClient.Config in neo SchedulingDlsClient constructor

sociomantic-tsunami / dlsproto

Distributed Log Store protocol definition, client, fake node, and tests

Boost Software License 1.0

3 stars 18 forks source link

Use SchedulingDlsClient.Config in neo SchedulingDlsClient constructor #24

Closed nemanja-boric-sociomantic closed 6 years ago

nemanja-boric-sociomantic commented 6 years ago

This patch fixes an apparent oversight in providing the neo constructor for SchedulingDlsClient: there is no need for a separate max_events parameter, given that it is already provided in the class' own custom Config class.

This should make it easier for users to transition to the neo protocol as it maintains consistency with the other Config-using constructor overloads of SchedulingDlsClient.

gavin-norman-sociomantic commented 6 years ago

Feel free to auto merge when green.