search

sociomantic-tsunami / dlsproto

Distributed Log Store protocol definition, client, fake node, and tests
Boost Software License 1.0
3 stars 18 forks source link

Use correct support for the const request API #3

Closed nemanja-boric-sociomantic closed 7 years ago

nemanja-boric-sociomantic commented 7 years ago

Instead of deserializing into the structure containing const fields, we're now serializing const instance of the mutable struct (enabling us to use the const API), but deserializing into the mutable struct.

gavin-norman-sociomantic commented 7 years ago

Could the lack of this PR cause problems? (i.e. this is a bug fix.)

nemanja-boric-sociomantic commented 7 years ago

No, not really. Since dlsproto doesn't have multidimensional arrays in the request arguments, it all works without it. This is just correct.

gavin-norman-sociomantic commented 7 years ago

I wonder about putting this in a minor release (refactoring). I think it's useful to keep patch releases as pure as possible.

nemanja-boric-sociomantic commented 7 years ago

I don't mind it that way.