search

sociomantic-tsunami / dlsproto

Distributed Log Store protocol definition, client, fake node, and tests
Boost Software License 1.0
3 stars 18 forks source link

Getrange v1 #39

Closed nemanja-boric-sociomantic closed 6 years ago

nemanja-boric-sociomantic commented 6 years ago

Blocked on making it work on DLS node.

nemanja-boric-sociomantic commented 6 years ago

I'll address your comments, but just unblocking this as I've confirmed this works with the node (after 4f905e1 commit being applied).

nemanja-boric-sociomantic commented 6 years ago

Updated with the comments addressed and with the batch compression.

gavin-norman-sociomantic commented 6 years ago

Ooh, I just remembered a trick David used recently in dmqproto that made reviewing way easier when doing a complete request rewrite like this. version(none) the old handler (v0) and add the new handler (v1) at the top of the module. Then add a second commit that removes the versioned out code.

nemanja-boric-sociomantic commented 6 years ago

Ah, good idea, I will update.

nemanja-boric-sociomantic commented 6 years ago

Updated.