sociomantic-tsunami / dlsproto

Distributed Log Store protocol definition, client, fake node, and tests
Boost Software License 1.0
3 stars 18 forks source link

Test with newer versions of DMD, including upstream #41

Closed mathias-lang-sociomantic closed 6 years ago

mathias-lang-sociomantic commented 6 years ago

:tada:

nemanja-boric-sociomantic commented 6 years ago

:+1:

nemanja-boric-sociomantic commented 6 years ago

Maybe push ocean to alpha.3 now :angel: :-)

mathias-lang-sociomantic commented 6 years ago

Hum, it needs unregisterSocket to be implemented in the DlsConnectionHandler. But judging from the code, it might be better to implement it in swarm directly. In which case swarm have to be updated first. What do you think ?

nemanja-boric-sociomantic commented 6 years ago

Hm, that's strange, because they should implement IFiberConnectionHandlerBase, which already implements this.

nemanja-boric-sociomantic commented 6 years ago

So, this class should be implemented by DlsConnectionHandler: https://github.com/sociomantic-tsunami/swarm/blob/v4.x.x/src/swarm/node/connection/ConnectionHandler.d#L381-L382

and that extends this ocean class, which already has this:

https://github.com/sociomantic-tsunami/ocean/blob/v4.x.x/src/ocean/net/server/connection/IFiberConnectionHandler.d#L224

nemanja-boric-sociomantic commented 6 years ago

Updating your branch to v4.0.0-alpha.2 works for me.

nemanja-boric-sociomantic commented 6 years ago

Oh, I just realized what I just did. It needs alpha 3.

nemanja-boric-sociomantic commented 6 years ago

Ah, damn, it fails on the FlexibleByteQueue changes in the ocean v4.0.0. This needs swarm update, that's for sure. cc @david-eckardt-sociomantic @mihails-strasuns-sociomantic

mathias-lang-sociomantic commented 6 years ago

In the meantime can we bring this in ? My point is to ensure that we get all tsunami projects to compile with upstream, not ensure compatibility with the newest ocean.

nemanja-boric-sociomantic commented 6 years ago

Thanks for the work!