Closed mathias-lang-sociomantic closed 6 years ago
:+1:
Maybe push ocean to alpha.3 now :angel: :-)
Hum, it needs unregisterSocket
to be implemented in the DlsConnectionHandler
.
But judging from the code, it might be better to implement it in swarm directly. In which case swarm have to be updated first.
What do you think ?
Hm, that's strange, because they should implement IFiberConnectionHandlerBase
, which already implements this.
So, this class should be implemented by DlsConnectionHandler
: https://github.com/sociomantic-tsunami/swarm/blob/v4.x.x/src/swarm/node/connection/ConnectionHandler.d#L381-L382
and that extends this ocean class, which already has this:
Updating your branch to v4.0.0-alpha.2
works for me.
Oh, I just realized what I just did. It needs alpha 3.
Ah, damn, it fails on the FlexibleByteQueue
changes in the ocean v4.0.0. This needs swarm update, that's for sure. cc @david-eckardt-sociomantic @mihails-strasuns-sociomantic
In the meantime can we bring this in ? My point is to ensure that we get all tsunami projects to compile with upstream, not ensure compatibility with the newest ocean.
Thanks for the work!
:tada: