search

sociomantic-tsunami / dlsproto

Distributed Log Store protocol definition, client, fake node, and tests
Boost Software License 1.0
3 stars 18 forks source link

Always resume RecordStream fiber when user issues stop #94

Closed nemanja-boric-sociomantic closed 6 years ago

nemanja-boric-sociomantic commented 6 years ago

Previously, if RecordStream was suspended, issuing a stop from a controller would resume it only if is waiting for the node to deliver more data. This however doesn't work if user suspended the request, and while suspended, they try to stop it (one example of this situation would be where the user stops the request when receiving node_disconnected, which by definition gets dispatched asynchronously from the request).

Now the RecordStream is resumed if it's waiting for the records from the node or if it's suspended explicitly.

gavin-norman-sociomantic commented 6 years ago

Shouldn't this be a patch release?

nemanja-boric-sociomantic commented 6 years ago

v14.1.0 was not yet released (only few rc releases), so there's nothing yet to patch.

gavin-norman-sociomantic commented 6 years ago

Ah cool. LGTM.