search

sociomantic-tsunami / dlsproto

Distributed Log Store protocol definition, client, fake node, and tests
Boost Software License 1.0
3 stars 18 forks source link

Add log messages GetRange request #95

Closed nemanja-boric-sociomantic closed 5 years ago

nemanja-boric-sociomantic commented 6 years ago

It's helpful to add info/trace messages to ease the debugging of the GetRange request.

nemanja-boric-sociomantic commented 6 years ago

I was also a bit on the edge here, but I found the precedent in dhtproto's ChannelMirror :-) (and this entire thing was inspired by it).

gavin-norman-sociomantic commented 6 years ago

I was going to say that the channel mirror logging is more on the level of API-features, but actually it isn't really. It's largely about the internal implementation (a bundled GetAll and Listen request).

nemanja-boric-sociomantic commented 6 years ago

I think that as well. I think it's not that hard to remove this info if you don't need it, and even when that's not done, using the info level, this should not be spam the application log, but it should reflect the actions of the user.

nemanja-boric-sociomantic commented 6 years ago

Testing this in production shows that the trace level is too chatty - it seems that Got a batch of records log event generates gigabytes of data in half of hour, so I'll have to shrink that down.

nemanja-boric-sociomantic commented 5 years ago

I don't think we're going to move forward with this one. Closing.