search

sociomantic-tsunami / dmxnet

D bindings and wrapper library for the MXNet deep learning library
Boost Software License 1.0
14 stars 11 forks source link

Remove or replace all imports of ocean.transition #96

Closed joseph-wakeling-sociomantic closed 5 years ago

joseph-wakeling-sociomantic commented 5 years ago

For modules that use the istring, cstring or mstring aliases, we replace ocean.transition imports with ocean.meta.types.Qualifiers. In all other modules the ocean.transition import is just dropped, as dmxnet no longer uses any of the functionality it defines.

jens-mueller-sociomantic commented 5 years ago

An alternative here could have been to replace istring with string, cstring with const(char)[] and mstring with char[]. Then the import could be removed entirely.

joseph-wakeling-sociomantic commented 5 years ago

Yes, but that's non-idiomatic within our library space. We can discuss that for the future but for now at least probably best to go with existing standards.