sociomantic-tsunami / libdrizzle-redux

The next generation of Libdrizzle with a simplified API and support for more features of the protocol
Other
13 stars 12 forks source link

Use nullptr instead of NULL in library code #332

Open bokchan opened 5 years ago

bokchan commented 5 years ago

The library is compiled with the c++11 standard which recommends using nullptr instead of NULL

ben-palmer-sociomantic commented 5 years ago

LGTM

ben-palmer-sociomantic commented 5 years ago

Could this just go in v6.2.0?

bokchan commented 5 years ago

Could this just go in v6.2.0?

Yes it could. Planning to make v7.0 use more c++11 features/guidelines, so would rather wait and bundle it with the next major release

codecov-io commented 5 years ago

Codecov Report

Merging #332 into v7.x.x will not change coverage. The diff coverage is 13.61%.