sociomantic-tsunami / nessie-ui

Diverse and robust React component library
https://sociomantic-tsunami.github.io/nessie-ui/
MIT License
9 stars 14 forks source link

[Flex/FlexItem] Create components #594

Open daniel-martic-sociomantic opened 6 years ago

daniel-martic-sociomantic commented 6 years ago

Currently

We're implementing Grid component based on CSS Grid, and we should test and see if this is (and how) affecting Row and Column, since both are based on CSS Flex and they (more or less) relied on the old implementation of Grid component.

Wanted

Both Row and Column should be independent of Grid component. Row should be a flex container that lays items in row direction, while Column a flex container laying items in column direction. Also, it would come handy if we can provide both with reverse direction (e.g. if user wants to put items right-left or bottom-up).

If needed, remove all unnecessary styles and props.

daniel-martic-sociomantic commented 6 years ago

This is a breaking change that'll take some time to adjust. We'll revisit this issue sometime in the future; for now we'll leave it as it is.

daniel-martic-sociomantic commented 5 years ago

Instead of having a separate components Row and Column, maybe it's better to have only one, Flex ( or maybe FlexContainer, FlexWrapper ? ), that will support both row and column directions for displaying items using flex. Then, same as we did with Grid, we could make another wrapper component FlexItem for extra flexibility 😎

conor-cafferkey-sociomantic commented 5 years ago

Sounds good to me ☝️