Open daniel-martic-sociomantic opened 6 years ago
This is a breaking change that'll take some time to adjust. We'll revisit this issue sometime in the future; for now we'll leave it as it is.
Instead of having a separate components Row
and Column
, maybe it's better to have only one, Flex
( or maybe FlexContainer
, FlexWrapper
? ), that will support both row and column directions for displaying items using flex. Then, same as we did with Grid
, we could make another wrapper component FlexItem
for extra flexibility 😎
Sounds good to me ☝️
Currently
We're implementing
Grid
component based on CSS Grid, and we should test and see if this is (and how) affectingRow
andColumn
, since both are based on CSS Flex and they (more or less) relied on the old implementation ofGrid
component.Wanted
Both
Row
andColumn
should be independent ofGrid
component.Row
should be aflex
container that lays items inrow
direction, whileColumn
aflex
container laying items incolumn
direction. Also, it would come handy if we can provide both withreverse
direction (e.g. if user wants to put items right-left or bottom-up).If needed, remove all unnecessary styles and props.