sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D
Other
61 stars 56 forks source link

code.dlang.org repository URL is outdated #788

Closed s-ludwig closed 4 years ago

s-ludwig commented 4 years ago

Just stumbled over the fact that the ocean-d2 package on code.dlang.org still references "sociomantic-tsunami/ocean-d2" instead of "sociomantic-tsunami/ocean" and didn't get any updates since 2017. This can be changed under "Manage packages" -> "ocean-d2" -> "Repository".

Geod24 commented 4 years ago

CC @mihails-strasuns @llucax

llucax commented 4 years ago

I think ocean never really had an "official" dub package, it was done as an experiment in this other repo. Since I'm not involved in Ocean anymore, pinging @ben-palmer-sociomantic @daniel-zullo-sociomantic and @joseph-wakeling-frequenz as people that might be interested in getting proper dub support in ocean.

mihails-strasuns commented 4 years ago

AFAIR Hatem has originally created that dub package so there is a high chance account access is lost now. Better probably to remove it and re-create anew if needed.

s-ludwig commented 4 years ago

I could also change the owner manually to anyone else who has an account there.

mihails-strasuns commented 4 years ago

That is a call for current ocean maintainers to make :)

ben-palmer-sociomantic commented 4 years ago

I think we should remove it as it is outdated and we are not planning on maintaining a dub package. If anyone else wants to take it on though they can feel free.

don-clugston-sociomantic commented 4 years ago

Hatem created this package from personal interest, in relation to a presentation he gave at dconf. We don't use dub internally so it's unsurprising that it's hopelessly outdated.

mihails-strasuns commented 4 years ago

Note that there is a dub.sdl in the default ocean branch but it is not tested by the ocean CI. If it was, updates to the registry would come for free (afair code.dlang.org checks new versions of registered repos automatically).

Maybe that is something @joseph-wakeling-frequenz wants to take over? I have memories that you have used ocean via dub.

joseph-wakeling-frequenz commented 4 years ago

I haven't really used it so far, I just made a few provisional tests of using dub rather than make to build/test the library. I'll think about what I can do but in the short term I would be reluctant to take on something I'm not 100% sure I can commit to.

Geod24 commented 4 years ago

I see two points here:

The dub.sdl file works just fine, and we are using it. I surely hope it won't go away. The registry registration is the part that is broken. We (obviously) don't use it, relying on submodules instead, but since it is a rather low maintenance thing, you can assign it to me @s-ludwig .

ben-palmer-sociomantic commented 4 years ago

Thanks @Geod24 !

s-ludwig commented 4 years ago

@Geod24: Done!

Geod24 commented 4 years ago

@s-ludwig : Actually it seems that the name of the package and the Github repository need to match ??

The package name of the new repository doesn't match the existing one: ocean

So I just deleted it (there were 17 total downloads anyway) and re-created it, proper: http://code.dlang.org/packages/ocean

oraby commented 4 years ago

Just to bring context to the reasoning behind the decision back then: I've created the dub entry under the name ocean-d2 such that I'd leave the entry named just ocean to when the actual ocean repo (one this repo) is in D2. The goal back then was to have the ocean-d2 repo automatically converted with each ocean release. This plan was dropped quickly afterwards though in favour of other plans. I wasn't part though of that decision process.

If I remember correctly, the reasoning behind using a personal account was actually to avoid the situation where we need to update the repo info but we lose the access to the sociomantic email. All of that happened, but you've guys managed already in other ways :+1: .

Geod24 commented 4 years ago

@Oraby: Thanks for the context :)

I think this issue can be closed