sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D

Other

61 stars 56 forks source link

Deprecate `ocean.core.Time` #812

Closed Geod24 closed 4 years ago

Geod24 commented 4 years ago

Now that Ocean is D2 only, we can simply replace this with the druntime variant, which was not possible before because Tango didn't have it.

codecov[bot] commented 4 years ago

Codecov Report

Merging #812 into v5.x.x will increase coverage by 0.00%. The diff coverage is n/a.

Geod24 commented 4 years ago

CC @don-clugston-sociomantic :)

don-clugston-sociomantic commented 4 years ago

The only places in our codebase where I found this module referenced are:

swarm/submodules/turtle/src/turtle/runner/Runner.d:25:import ocean.core.Time;
dhtproto/src/dummydhtapp/main.d:32:import ocean.core.Time;
dmqproto/src/dummydmqapp/main.d:90:    import ocean.core.Time;

I prefer to remove all usage of something before marking it as deprecated. So either make PRs for those three, or remove the actual deprecation from this one. Then I will merge it.

Geod24 commented 4 years ago

I prefer to remove all usage of something before marking it as deprecated.

Agreed.

don-clugston-sociomantic commented 4 years ago

LGTM. Will merge the Turtle PR later.