search

sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D
Other
61 stars 56 forks source link

Deprecate most modules in ocean.time.chrono #818

Closed Geod24 closed 4 years ago

Geod24 commented 4 years ago 
The Calendar, Gregorian, and GregorianBased types are actually widely used,
but those 6 calendars are not, so they are an easy target for deprecation.

~Blocked by https://github.com/sociomantic-tsunami/ocean/pull/817 as I need to add it to the list of deprecated modules in the makefile and dub.sdl, but this other PR will conflict.~

Geod24 commented 4 years ago

Rebase on v5.x.x, no longer blocker @ben-palmer-sociomantic

codecov[bot] commented 4 years ago

Codecov Report

Merging #818 into v5.x.x will increase coverage by 0.25%. The diff coverage is n/a.

codecov[bot] commented 4 years ago

Codecov Report

Merging #818 into v5.x.x will increase coverage by 0.25%. The diff coverage is n/a.

codecov[bot] commented 4 years ago

Codecov Report

Merging #818 into v5.x.x will increase coverage by 0.25%. The diff coverage is n/a.

Geod24 commented 4 years ago

Ping @ben-palmer-sociomantic

Geod24 commented 4 years ago

... or @don-clugston-sociomantic :)

don-clugston-sociomantic commented 4 years ago

LGTM. Waiting for the backlash from the users of the ThaiBuddhist calender. I never understood why these were included and the Mayan calender was not.