sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D

Other

61 stars 56 forks source link

Clear up some more extern(C) declarations #821

Closed Geod24 closed 4 years ago

Geod24 commented 4 years ago

Better reviewed commit-by-commit.

codecov[bot] commented 4 years ago

Codecov Report

Merging #821 into v5.x.x will decrease coverage by 0.00%. The diff coverage is 100.00%.

Geod24 commented 4 years ago

Travis, why are you like this ? Can someone retrigger the CI ? It's a network error... CC @ben-palmer-sociomantic @don-clugston-sociomantic

don-clugston-sociomantic commented 4 years ago

This basically looks good, but could you please move the deprecation commits (timerfd, pthread) into a PR which is different from the cleanup stuff. I notice that ThreadWorker is modified in both, so the cleanup one would have to be merged first, If you split it off into a separate PR I will just merge them, we don't need to wait for Travis since we know it passes.

Geod24 commented 4 years ago

Removed the two deprecation commits, will submit a new PR once this is merged.

don-clugston-sociomantic commented 4 years ago

LGTM