sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D

Other

61 stars 56 forks source link

Fix 827 - SmartUnion generates conflicting opCalls #831

Closed MoonlightSentinel closed 4 years ago

MoonlightSentinel commented 4 years ago

Only generate opCall for members with unique types. This bug wasn't reported due to [1] but the generated opCalls were unusable anyway (calling them caused an ambiguity error).

[1] https://issues.dlang.org/show_bug.cgi?id=2789

Note: I hope this is the correct target branch(?)

codecov[bot] commented 4 years ago

Codecov Report

Merging #831 into v5.x.x will increase coverage by 0.00%. The diff coverage is 100.00%.

Geod24 commented 4 years ago

So... It will just generate an opCall for whatever first method is encountered ?

MoonlightSentinel commented 4 years ago

Not anymore. The generated opCalls weren't callable anyway due to the ambiguity so this shouldn't break other code.

Geod24 commented 4 years ago

SGTM. Just needs a release note

Geod24 commented 4 years ago

Added release notes, fixed the typos.

MoonlightSentinel commented 4 years ago

Thank you @Geod24