search

sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D
Other
61 stars 56 forks source link

HttpStack: Use assert(0) instead of abort() #840

Closed Geod24 closed 3 years ago

Geod24 commented 3 years ago

assert(0) will be lowered to an HLT in release mode. This blocks upstream DMD, as DIP1034 will introduce noreturn, which correctly detects that abort does not return, and subsequently triggers a "Statement is not reachable" on the return.

codecov[bot] commented 3 years ago

Codecov Report

Merging #840 (3970ebd) into v6.x.x (81050e0) will decrease coverage by 0.00%. The diff coverage is 0.00%.

Geod24 commented 3 years ago

Of course 0% of diff hit, it's an assert(0).