Closed Geod24 closed 3 years ago
The rest looks theoretically good, except for the fact that I don't see the GitHub tests actually running for this PR :-\
It will only start to show up once merged, hence why I linked to the run in my fork.
Finally: is pushing straight to the latest 6.x.x branch sufficient? Do we want to apply this to any earlier versions and merge into later versions and the major-version dev branch(es)? Up to you as the driver of active development right now.
I really don't want to spend more time on Ocean that is necessary, unless we see more users. I'm currently the sole maintainer and developer, and while I will follow the deprecation process and SemVer guarantee, I have no intention to provide support for older version for non-existing users.
I'm moving ahead with this because upstream DMD needs a new release to make progress on DIP1034. See last comment in https://github.com/dlang/dmd/pull/12222 .
This works rather well: https://github.com/Geod24/ocean/runs/1977736677?check_suite_focus=true