Closed Geod24 closed 3 years ago
Hmm, it seems these changes somewhat affect template instantiation somewhere else.
Yeah, the testsuite results say that there's a little more that needs to be done in order to get it working.
Yep, needs to deal with isFloatingPoint
.
Worked around by not deprecating the isComplexType
. I don't think there's any users, and if there is, well the next major is going to break their code.
Worked around by not deprecating the
isComplexType
. I don't think there's any users, and if there is, well the next major is going to break their code.
Maybe add something via pragma(msg) to notify people to stop using this function but without actual depreciation?
Maybe add something via pragma(msg) to notify people to stop using this function but without actual depreciation?
Well it's used in isFloatingPoint
, so it would trigger in unrelated code.
Rebasing now, and will test in our application to see if other deprecations are being triggered.
I can confirm, all gone :)
At least I know who'll review this :)