search

sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D
Other
61 stars 56 forks source link

Deprecate functions using creal or ireal #851

Closed Geod24 closed 3 years ago

Geod24 commented 3 years ago

At least I know who'll review this :)

alaksiej-stankievicx-dunnhumby commented 3 years ago

Hmm, it seems these changes somewhat affect template instantiation somewhere else.

ibuclaw commented 3 years ago

Yeah, the testsuite results say that there's a little more that needs to be done in order to get it working.

Geod24 commented 3 years ago

Yep, needs to deal with isFloatingPoint.

codecov[bot] commented 3 years ago

Codecov Report

Merging #851 (58be614) into v6.x.x (8232334) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Geod24 commented 3 years ago

Worked around by not deprecating the isComplexType. I don't think there's any users, and if there is, well the next major is going to break their code.

alaksiej-stankievicx-dunnhumby commented 3 years ago

Worked around by not deprecating the isComplexType. I don't think there's any users, and if there is, well the next major is going to break their code.

Maybe add something via pragma(msg) to notify people to stop using this function but without actual depreciation?

Geod24 commented 3 years ago

Maybe add something via pragma(msg) to notify people to stop using this function but without actual depreciation?

Well it's used in isFloatingPoint, so it would trigger in unrelated code.

Geod24 commented 3 years ago

Rebasing now, and will test in our application to see if other deprecations are being triggered.

Geod24 commented 3 years ago

I can confirm, all gone :)