search

sociomantic-tsunami / ocean

General purpose, platform-dependent, high-performance library for D
Other
61 stars 56 forks source link

Replace all usages of 'istring' with 'string' #860

Closed Geod24 closed 2 years ago

Geod24 commented 2 years ago 
Now that Ocean is D2-only, this trivial alias doesn't make sense,
and make code harder to use outside Ocean.
Geod24 commented 2 years ago

Heh there's some typeid shenanigans

codecov[bot] commented 2 years ago

Codecov Report

Merging #860 (2a3bca8) into v6.x.x (977e6b7) will decrease coverage by 0.00%. The diff coverage is 61.41%.

:exclamation: Current head 2a3bca8 differs from pull request most recent head bd6376d. Consider uploading reports for the commit bd6376d to get more accurate results

Geod24 commented 2 years ago

Found the bug, it was a name conflict with a string member. Will submit as a separate PR to make sure the commit is atomic.