sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Convert assert -> verify in swarm.neo (excluding client) #241

Closed gavin-norman-sociomantic closed 6 years ago

gavin-norman-sociomantic commented 6 years ago

Part of #200.

nemanja-boric-sociomantic commented 6 years ago

Travis says no.

gavin-norman-sociomantic commented 6 years ago

? Travis says nothing at all, afaics.

nemanja-boric-sociomantic commented 6 years ago

Did you update the code in the past few minutes? I remember seeing travis fails with the assertions triggering in D2 builds in ConnectionBase?

gavin-norman-sociomantic commented 6 years ago

I rebased and pushed maybe 10 mins ago.

nemanja-boric-sociomantic commented 6 years ago

Yes, that matches the time of my comment. I think this is just a race condition.

gavin-norman-sociomantic commented 6 years ago

I can see a D2 problem locally, anyway. Investigating.

gavin-norman-sociomantic commented 6 years ago

Rebased.

gavin-norman-sociomantic commented 6 years ago

Build hung at xenial-v2: Pulling from sociomantictsunami/dlang. Restarting.

gavin-norman-sociomantic commented 6 years ago

Green now.