sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Enhance BatchRequestCore (and implement node-side equivalent) #243

Open gavin-norman-sociomantic opened 6 years ago

gavin-norman-sociomantic commented 6 years ago

The existing request core is fairly minimal. I'm sure there's a lot more common code that could be added (basic fiber implementations, for example).

Ditto for the node side of the equation (where no core code exists atm).

gavin-norman-sociomantic commented 6 years ago

This could include the whole record batch management, as well (on both sides).

gavin-norman-sociomantic commented 6 years ago

It should use the new record batcher, too.

gavin-norman-sociomantic commented 6 years ago

Should probably include https://github.com/sociomantic-tsunami/dlsproto/pull/84 by default.

nemanja-boric-sociomantic commented 6 years ago

Btw, I the code pretty much ready, I'll clean it up and submit a PR in the next few days. I've successfully converted DMQ's Consume request and DLS's GetRange reqeuest to use it.

nemanja-boric-sociomantic commented 6 years ago

Oh, yes, I think it should include that feature by default (it also includes double-buffering).

gavin-norman-sociomantic commented 6 years ago

Should use https://github.com/sociomantic-tsunami/swarm/blob/v4.x.x/src/swarm/neo/util/Batch.d internally (at the request's option?).

nemanja-boric-sociomantic commented 6 years ago

Feature: extend finished notification to indicate the number of nodes where the request finished successfully/with an error.

nemanja-boric-sociomantic commented 6 years ago

related: https://github.com/sociomantic-tsunami/dmqproto/issues/72#issuecomment-405617657

gavin-norman-sociomantic commented 5 years ago

Btw, I the code pretty much ready, I'll clean it up and submit a PR in the next few days. I've successfully converted DMQ's Consume request and DLS's GetRange reqeuest to use it.

:(

gavin-norman-sociomantic commented 5 years ago

Moved to v5.5.0.