RecordStream: Avoid reading one char at a time, if we can help it

sociomantic-tsunami / swarm

Asynchronous client/node framework library

Boost Software License 1.0

14 stars 26 forks source link

RecordStream: Avoid reading one char at a time, if we can help it #247

Closed mathias-lang-sociomantic closed 6 years ago

mathias-lang-sociomantic commented 6 years ago

Add some tests
Fix some ridiculously poor performances

mathias-lang-sociomantic commented 6 years ago

Updated

mihails-strasuns-sociomantic commented 6 years ago

It looks like this has introduced a regression in swarmtools - those now fail if input stream is large enough with:

terminated after throwing an uncaught instance of 'ocean.core.ExceptionDefinitions.IOException' at ./submodules/ocean/src/ocean/io/device/Conduit.d:190
  toString():  BufferedInput.next :: input buffer is full

mathias-lang-sociomantic commented 6 years ago

There's also https://github.com/sociomantic-tsunami/swarm/pull/265 But it doesn't look related :(