sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Re-add accidentally removed constant in RecordBatch #304

Closed gavin-norman-sociomantic closed 6 years ago

gavin-norman-sociomantic commented 6 years ago

Fixes a bug in unrelease code in v5.x.x.

nemanja-boric-sociomantic commented 6 years ago

Actually, this needs to be applied to the v4.6.x since the existing code is broken: https://github.com/sociomantic-tsunami/swarm/blob/f337984496e0f08d08f4be5997b4272d9c0e0dab/src/swarm/util/RecordBatcher.d#L446

This is the commit that broke it: https://github.com/sociomantic-tsunami/swarm/commit/4a3b231848cc09957e32276c060196cdf4e8da50#diff-2e8543d3803639dbe31ba37f78932691

gavin-norman-sociomantic commented 6 years ago

Mm, my reading of the branch history doesn't agree. It does look like this needs to be applied to v4.x.x, though (not v5.x.x).

gavin-norman-sociomantic commented 6 years ago

Yeah, at v4.6.2 (b632c1a16fa4a3763f3e5354c7fb60186777ff7a), RecordBatchBase still exists: https://github.com/sociomantic-tsunami/swarm/blob/b632c1a16fa4a3763f3e5354c7fb60186777ff7a/src/swarm/util/RecordBatcher.d#L36

nemanja-boric-sociomantic commented 6 years ago

Yes, sorry, it's the v4.x.x (this is where I found the error.)

gavin-norman-sociomantic commented 6 years ago

Rebased on v4.x.x.

nemanja-boric-sociomantic commented 6 years ago

Very interesting D2 failure that I can't explain for this diff?

gavin-norman-sociomantic commented 6 years ago

Weird. Seemingly unrelated visibility issues.

nemanja-boric-sociomantic commented 6 years ago

Yeah, it's travis targeting the v5.x.x branch.

gavin-norman-sociomantic commented 6 years ago

test this please travis